sniblocking: cache recent results #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids requesting several times in a row for the control SNI, which is frankly a waste of time when checkoing multiple inputs. While there, make sure we never use ps.ooni.io as the helper. A bunch of places in tests were still using it, which is generally fine but being consistent is most likely gonna be better. Part of #309.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids requesting several times in a row for the control SNI, which
is frankly a waste of time when checkoing multiple inputs.
While there, make sure we never use ps.ooni.io as the helper. A bunch
of places in tests were still using it, which is generally fine but
being consistent is most likely gonna be better.
Part of #309.